Skip to content

Polish 'AbstractServletWebServerFactory.configureSessionCookie()' #26478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Polish 'AbstractServletWebServerFactory.configureSessionCookie()' #26478

wants to merge 1 commit into from

Conversation

@weixsun
Copy link
Contributor

@weixsun weixsun commented May 16, 2021

Polish AbstractServletWebServerFactory with PropertyMapper.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 16, 2021
@weixsun weixsun changed the title Polish 'AbstractServletWebServerFactory' Polish 'AbstractServletWebServerFactory.configureSessionCookie()' May 16, 2021
@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels May 16, 2021
@snicoll snicoll added this to the 2.5.0 milestone May 16, 2021
@snicoll snicoll self-assigned this May 16, 2021
@snicoll snicoll mentioned this pull request May 16, 2021
Closed
@snicoll
Copy link
Member

snicoll commented May 16, 2021

@weixsun thanks again for the PR. This looked very sensible but it actually broke the build. This change turned out to reveal, I think, a problem in our test setup. I have opened #26479 to investigate.

@snicoll snicoll added the status: on-hold We can't start working on this issue yet label May 16, 2021
@weixsun weixsun force-pushed the polish-AbstractServletWebServerFactory branch from c968665 to d986757 Compare May 16, 2021 20:18
@snicoll snicoll modified the milestones: 2.5.0, 2.6.x May 17, 2021
snicoll pushed a commit that referenced this pull request May 17, 2021
@weixsun @snicoll
Polish AbstractServletWebServerFactory
935199b 
See gh-26478
snicoll added a commit that referenced this pull request May 17, 2021
@snicoll
Update copyright year of changed files
e9174c1 
See gh-26478
@snicoll snicoll closed this in 81d1c2e May 17, 2021
@snicoll
Copy link
Member

snicoll commented May 17, 2021

Thanks again @weixsun

@weixsun weixsun deleted the polish-AbstractServletWebServerFactory branch May 23, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snicoll snicoll snicoll approved these changes

Assignees

@snicoll snicoll

Labels

status: on-hold We can't start working on this issue yet type: task A general task

Projects

None yet

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@weixsun @snicoll @spring-projects-issues